Messages in this thread | | | Date | Fri, 2 Oct 2020 14:40:47 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] serial: max310x: rework RX interrupt handling |
| |
On Wed, Sep 30, 2020 at 05:54:15PM +0300, Andy Shevchenko wrote: > On Wed, Sep 30, 2020 at 5:50 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > On Wed, 30 Sep 2020 17:24:48 +0300 > > Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > > > On a Microchip SAMA5D3 platform that is receiving 20 bytes every 16ms > > > > over one MAX310X UART, this patch has allowed to reduce the CPU > > > > consumption of the interrupt handler thread from ~25% to 6-7%. > > > > > > Was it always like this? > > > > As far as I can see, yes. I guess you were thinking about a Fixes: tag > > perhaps? I don't think a Fixes: tag really applies here, as we're not > > fixing a performance regression. > > Thanks for elaboration. > > ... > > > > > + /* Reset FIFOs*/ > > > > > > Add a space before the asterisk. > > > > Indeed. Let me know if a v2 is needed, or if this small typo can be > > fixed when applying. > > Greg usually doesn't touch commits, so v2 would be better.
Agreed, I don't like to edit things :)
| |