lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] block: scsi_ioctl: Avoid the use of one-element arrays
From
Date
On 10/2/20 5:10 PM, Gustavo A. R. Silva wrote:
> diff --git a/include/uapi/linux/cdrom.h b/include/uapi/linux/cdrom.h
> index 2817230148fd..6c34f6e2f1f7 100644
> --- a/include/uapi/linux/cdrom.h
> +++ b/include/uapi/linux/cdrom.h
> @@ -289,7 +289,10 @@ struct cdrom_generic_command
> unsigned char data_direction;
> int quiet;
> int timeout;
> - void __user *reserved[1]; /* unused, actually */
> + union {
> + void __user *reserved[1]; /* unused, actually */
> + void __user *unused;
> + };

What's the point of this union, why not just turn it into

void * __user *unused;

?

--
Jens Axboe

\
 
 \ /
  Last update: 2020-10-03 01:53    [W:0.065 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site