Messages in this thread | | | Date | Mon, 19 Oct 2020 15:14:23 -0500 | From | Segher Boessenkool <> | Subject | Re: [PATCH 2/3] powerpc: Fix incorrect stw{, ux, u, x} instructions in __set_pte_at |
| |
On Mon, Oct 19, 2020 at 12:12:47PM +0000, Christophe Leroy wrote: > From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > The placeholder for instruction selection should use the second > argument's operand, which is %1, not %0. This could generate incorrect > assembly code if the instruction selection for argument %0 ever differs > from argument %1.
"Instruction selection" isn't correct here... "if the memory addressing of operand 0 is a different form from that of operand 1", perhaps?
The patch looks fine of course :-)
Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
| |