Messages in this thread | | | Date | Mon, 19 Oct 2020 19:06:41 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] drm: remove unneeded break |
| |
Hi Tom On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > A break is not needed if it is preceded by a return or break > > Signed-off-by: Tom Rix <trix@redhat.com>
Looks good and builds with no warnings.
One of the diffs made me - "oh this looks wrong". But after I looked again it was right and the resulting code is more readable - so good.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Was tempted to just apply to drm-misc-next but will give others the opportunity to chime in.
Sam
| |