Messages in this thread | | | Subject | Re: [PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices | From | Joe Perches <> | Date | Mon, 19 Oct 2020 09:54:59 -0700 |
| |
On Mon, 2020-10-19 at 16:40 +0000, Srinivasan Raju wrote: > > Overall, there are many magic numbers without comments, this makes it hard to > > understand the code. Using defines with proper naming helps and for 802.11 stuff > > can use ieee80211_*/IEEE80211_* should be used. > > Thanks for your comments Krishna, will work on them.
When you do, please start adding changelog information below the --- line to your patches.
It's quite a chore to figure out what changed between revisions.
| |