lkml.org 
[lkml]   [2020]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.
On Mon, 19 Oct 2020 08:51:04 +0000 Henrik Bjoernlund wrote:
> Thank you for the review. Comments below.
>
> The 10/15/2020 10:34, Jakub Kicinski wrote:
> >
> > On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote:
> > > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = {
> > > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 },
> >
> > NLA_POLICY_MAX(NLA_U32, 7)
>
> I will change as requested.
>
> >
> > Also why did you keep the validation in the code in patch 4?
>
> In patch 4 there is no CFM NETLINK so I desided to keep the validation in the
> code until NETLINK was added that is now doing the check.
> I this a problem?

Nothing calls those functions until patch 7, so there's no need for
that code to be added.

\
 
 \ /
  Last update: 2020-10-19 18:25    [W:0.059 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site