lkml.org 
[lkml]   [2020]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it
Date
Hi Geert,

Thank you for the patch!

On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> user may not want to enable. Fix this by making the test depend on
> MPTCP instead.

I think the initial intension was to select MPTCP to have an easy way to
enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.

But it probably makes sense to depend on MPTCP instead of selecting it.
So that's fine for me. But then please also send a patch to ext4
maintainer to do the same there.

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

\
 
 \ /
  Last update: 2020-10-19 17:47    [W:0.049 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site