lkml.org 
[lkml]   [2020]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 -tip 04/26] sched/fair: Add a few assertions
    Date
    From: Peter Zijlstra <peterz@infradead.org>

    Tested-by: Julien Desfossez <jdesfossez@digitalocean.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    ---
    kernel/sched/fair.c | 12 ++++++++++--
    1 file changed, 10 insertions(+), 2 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index bd6aed63f5e3..b4bc82f46fe7 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -6228,6 +6228,11 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
    }

    symmetric:
    + /*
    + * per-cpu select_idle_mask usage
    + */
    + lockdep_assert_irqs_disabled();
    +
    if (available_idle_cpu(target) || sched_idle_cpu(target))
    return target;

    @@ -6670,8 +6675,6 @@ static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu)
    * certain conditions an idle sibling CPU if the domain has SD_WAKE_AFFINE set.
    *
    * Returns the target CPU number.
    - *
    - * preempt must be disabled.
    */
    static int
    select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_flags)
    @@ -6682,6 +6685,11 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f
    int want_affine = 0;
    int sync = (wake_flags & WF_SYNC) && !(current->flags & PF_EXITING);

    + /*
    + * required for stable ->cpus_allowed
    + */
    + lockdep_assert_held(&p->pi_lock);
    +
    if (sd_flag & SD_BALANCE_WAKE) {
    record_wakee(p);

    --
    2.29.0.rc1.297.gfa9743e501-goog
    \
     
     \ /
      Last update: 2020-10-20 03:44    [W:4.302 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site