Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 18 Oct 2020 16:39:27 +0200 | Subject | Re: [PATCH] lib/test_free_pages: Add basic progress indicators |
| |
Hi Matthew,
On Sun, Oct 18, 2020 at 4:25 PM Matthew Wilcox <willy@infradead.org> wrote: > On Sun, Oct 18, 2020 at 04:04:45PM +0200, Geert Uytterhoeven wrote: > > The test module to check that free_pages() does not leak memory does not > > provide any feedback whatsoever its state or progress, but may take some > > time on slow machines. Add the printing of messages upon starting each > > phase of the test, and upon completion. > > It's not supposed to take a long time. Can you crank down that 1000 *
It took 1m11s on ARAnyM, running on an i7-8700K. Real hardware may even take longer.
> 1000 to something more appropriate?
What would be a suitable value? You do want to see it "leak gigabytes of memory and probably OOM your system" if something's wrong, so decreasing the value a lot may not be a good idea?
Regardless, if it OOMs, I think you do want to see this happens while running this test.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |