lkml.org 
[lkml]   [2020]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 20/29] virtio-mem: nb_sb_per_mb and subblock_size are specific to Sub Block Mode (SBM)
    On Fri, Oct 16, 2020 at 03:17:06PM +0200, David Hildenbrand wrote:
    >On 16.10.20 10:53, Wei Yang wrote:
    >> On Mon, Oct 12, 2020 at 02:53:14PM +0200, David Hildenbrand wrote:
    >>> Let's rename to "sbs_per_mb" and "sb_size" and move accordingly.
    >>>
    >>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
    >>> Cc: Jason Wang <jasowang@redhat.com>
    >>> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
    >>> Signed-off-by: David Hildenbrand <david@redhat.com>
    >>
    >> One trivial suggestion, could we move this patch close the data structure
    >> movement patch?
    >>
    >> I know this would be some work, since you have changed some of the code logic.
    >> This would take you some time to rebase.
    >
    >You mean after patch #17 ?

    Yes

    >
    >I guess I can move patch #18 (prereq) a little further up (e.g., after
    >patch #15). Guess moving it in front of #19 shouldn't be too hard.
    >
    >Will give it a try - if it takes too much effort, I'll leave it like this.
    >

    Not a big deal, while it will make the change more intact to me.

    This is a big patch set to me. In case it could be split into two parts, like
    bug fix/logic improvement and BBM implementation, that would be more friendly
    to review.

    >Thanks!
    >
    >--
    >Thanks,
    >
    >David / dhildenb

    --
    Wei Yang
    Help you, Help me

    \
     
     \ /
      Last update: 2020-10-18 14:41    [W:4.029 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site