Messages in this thread | | | From | Vaishnav M A <> | Date | Mon, 19 Oct 2020 01:31:39 +0530 | Subject | Re: [PATCH v3] iio: light: vcnl4035 add i2c_device_id |
| |
On Sun, Oct 18, 2020 at 11:59 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Oct 18, 2020 at 6:47 PM Vaishnav M A <vaishnav@beagleboard.org> wrote: > > > > Add i2c_device_id table for the vl53l0x-i2c driver, > > helps in device instantiation using i2c_new_client_device > > In all your patches please refer to the functions like function(). > For example, here is i2c_new_client_device(). > > > or from userspace in cases where device-tree based description > > is not possible now (Example: device on a gbphy i2c adapter > > created by greybus) > > Don't forget proper English punctuation, like periods at the end of sentences. > > -- > With Best Regards, > Andy Shevchenko
Thank you Andy for your review, I have updated v4 patch with your suggestions, https://lore.kernel.org/patchwork/patch/1322219/ (sorry about the incorrect driver name in the first-line of the commit message in the v3 version). This is also fixed in the v4 submission.
Thanks, Vaishnav
| |