lkml.org 
[lkml]   [2020]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.8 009/101] media: st-delta: Fix reference count leak in delta_run_work
    Date
    From: Aditya Pakki <pakki001@umn.edu>

    [ Upstream commit 57cc666d36adc7b45e37ba4cd7bc4e44ec4c43d7 ]

    delta_run_work() calls delta_get_sync() that increments
    the reference counter. In case of failure, decrement the reference
    count by calling delta_put_autosuspend().

    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/sti/delta/delta-v4l2.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c
    index 2503224eeee51..c691b3d81549d 100644
    --- a/drivers/media/platform/sti/delta/delta-v4l2.c
    +++ b/drivers/media/platform/sti/delta/delta-v4l2.c
    @@ -954,8 +954,10 @@ static void delta_run_work(struct work_struct *work)
    /* enable the hardware */
    if (!dec->pm) {
    ret = delta_get_sync(ctx);
    - if (ret)
    + if (ret) {
    + delta_put_autosuspend(ctx);
    goto err;
    + }
    }

    /* decode this access unit */
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-10-18 21:54    [W:4.103 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site