Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 16 Oct 2020 05:19:26 +0200 | Subject | Re: [PATCH v4 24/32] auxdisplay: Move char redefine code to hd44780_common |
| |
On Mon, Oct 5, 2020 at 3:01 PM <poeschel@lemonage.de> wrote: > > + while (*esc && cgoffset < 8) { > + shift ^= 4; > + if (*esc >= '0' && *esc <= '9') { > + value |= (*esc - '0') << shift; > + } else if (*esc >= 'A' && *esc <= 'F') { > + value |= (*esc - 'A' + 10) << shift; > + } else if (*esc >= 'a' && *esc <= 'f') { > + value |= (*esc - 'a' + 10) << shift;
I just noticed this is undoing commit 3f03b6498 ("auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code"). Lars?
Cheers, Miguel
| |