Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 16 Oct 2020 04:48:13 +0200 | Subject | Re: [PATCH v4 02/32] auxdisplay: Introduce hd44780_common.[ch] |
| |
On Mon, Oct 5, 2020 at 2:27 PM <poeschel@lemonage.de> wrote: > > diff --git a/drivers/auxdisplay/hd44780_common.c b/drivers/auxdisplay/hd44780_common.c > new file mode 100644 > index 000000000000..073f47397f7d > --- /dev/null > +++ b/drivers/auxdisplay/hd44780_common.c > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +#include <linux/module.h> > +#include <linux/slab.h> > + > +#include "hd44780_common.h" > + > +struct hd44780_common *hd44780_common_alloc(void) > +{ > + struct hd44780_common *hd; > + > + hd = kzalloc(sizeof(*hd), GFP_KERNEL); > + if (!hd) > + return NULL; > + > + return hd; > +
Typo: spurious newline.
> +} > +EXPORT_SYMBOL_GPL(hd44780_common_alloc); > + > +MODULE_LICENSE("GPL"); > +
Spurious EOF newline.
> diff --git a/drivers/auxdisplay/hd44780_common.h b/drivers/auxdisplay/hd44780_common.h > new file mode 100644 > index 000000000000..767bbda91744 > --- /dev/null > +++ b/drivers/auxdisplay/hd44780_common.h > @@ -0,0 +1,8 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > + > +struct hd44780_common { > + void *hd44780; > +}; > + > +struct hd44780_common *hd44780_common_alloc(void); > +
Spurious EOF newline.
(All already corrected in my queue).
Cheers, Miguel
| |