Messages in this thread | | | From | "Hans-Christian Egtvedt (hegtvedt)" <> | Subject | Re: [PATCH v4.4/bluetooth 1/2] Bluetooth: Consolidate encryption handling in hci_encrypt_cfm | Date | Thu, 15 Oct 2020 21:15:48 +0000 |
| |
On 15/10/2020 14:44, Hans-Christian Egtvedt (hegtvedt) wrote: > On 15/10/2020 14:02, Greg KH wrote: >> On Thu, Oct 15, 2020 at 11:18:39AM +0000, Hans-Christian Egtvedt (hegtvedt) wrote: >>> On 15/10/2020 11:57, Greg KH wrote: >>>> On Thu, Oct 15, 2020 at 09:43:32AM +0200, Hans-Christian Noren Egtvedt wrote: >>>>> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
<snipp embarrassing reference to local commit>
>>>>> --- >>>>> AFAICT, fixing CVE 2020-10135 Bluetooth impersonation attacks have been >>>>> left out for the 4.4 stable kernel. I cherry picked what I assume are >>>>> the appropriate two patches missing from the 4.9 stable kernel. Please >>>>> add them to upcoming 4.4 stable releases. >>>> >>>> Why are you merging 2 commits together? Please provide backports for >>>> all stable kernels, if you want to see this in the 4.4.y tree. We can >>>> not have someone move from an older tree to a newer one and have a >>>> regression. >>> >>> Agreed, I have managed to trick myself into thinking the 4.4.y branch >>> was left out, but I assume these patches are required for all LTS branches. >> >> They are, but if you have copies of them, please feel free to share >> them. > > I will repeat cherry-picking from a clean linux-stable git tree and send > patches, sorry for this noise. > > I see linux-5.8.y has partial patches, while the older branches need the > full series of three commits. I just discovered an additional fix.
I sent three iterations.
5.8.y only requires a single cherry-pick.
4.9.y to 5.4.y has non-conflicting cherry-pick from upstream commits.
4.4.y needs to resolve a conflict when cherry-picking.
I would still want Luiz to ack that this completes the mitigation for this Bluetooth vulnerability in the stable kernels.
-- Best regards, Hans-Christian Noren Egtvedt [unhandled content-type:application/pgp-keys] | |