Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 15 Oct 2020 14:43:51 +0200 | Subject | Re: [PATCH 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes |
| |
Hi Jacopo,
On Wed, Oct 14, 2020 at 11:40 AM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Add CSI-2 nodes to R8A779A0 R-Car V3U SoC. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks for your patch!
> The chip manual reports that the CSI-2 units are fed with S1D1 and S1D2 > clocks. The same applies to other SoCs, but none lists the two > additional clocks in the DTS node. So I left them out here as well.
As these clocks are always-on, and as long as the driver does't care about the actual clock rates, that is fine.
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -105,6 +105,47 @@ scif0: serial@e6e60000 { > status = "disabled"; > }; > > + csi40: csi2@feaa0000 { > + compatible = "renesas,r8a779a0-csi2"; > + reg = <0 0xfeaa0000 0 0x10000>; > + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 331>; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 331>; > + status = "disabled";
Missing "ports" subnode?
Apart from that: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |