lkml.org 
[lkml]   [2020]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.
On Mon, 12 Oct 2020 14:04:23 +0000 Henrik Bjoernlund wrote:
> + skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH);
> + if (!skb)
> + return NULL;
> +
> + rcu_read_lock();
> + b_port = rcu_dereference(mep->b_port);
> + if (!b_port) {
> + rcu_read_unlock();
> + return NULL;
> + }

At a quick scan I noticed you appear to be leaking the skb here.
So let me point out some more nit picks.

\
 
 \ /
  Last update: 2020-10-15 01:01    [W:0.121 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site