Messages in this thread | | | Subject | Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer | From | Alex Dewar <> | Date | Wed, 14 Oct 2020 10:45:55 +0100 |
| |
On 14/10/2020 10:32, Jakub Sitnicki wrote: > On Mon, Oct 12, 2020 at 07:09 PM CEST, Alex Dewar wrote: >> If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is >> called unconditionally on skb_verdict, even though it may be NULL. Fix >> and tidy up error path. >> >> Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWARD_NULL) >> Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs explicitly") >> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> >> --- > Note to maintainers: the issue exists only in bpf-next where we have: > > https://lore.kernel.org/bpf/160239294756.8495.5796595770890272219.stgit@john-Precision-5820-Tower/ > > The patch also looks like it is supposed to be applied on top of the above. Yes, the patch is based on linux-next.
| |