Messages in this thread Patch in this message | | | From | Aisheng Dong <> | Subject | RE: [PATCH] opp: Don't always remove static OPPs in _of_add_opp_table_v1() | Date | Thu, 15 Oct 2020 02:35:35 +0000 |
| |
Hi Viresh
Thanks for the quick fix.
> From: Viresh Kumar <viresh.kumar@linaro.org> > Sent: Wednesday, October 14, 2020 12:26 PM > > The patch missed returning 0 early in case of success and hence the static OPPs > got removed by mistake. Fix it. > > Fixes: 90d46d71cce2 ("opp: Handle multiple calls for same OPP table in > _of_add_opp_table_v1()") > Reported-by: Aisheng Dong <aisheng.dong@nxp.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards Aisheng
> --- > drivers/opp/of.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c index > 874b58756220..9faeb83e4b32 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -944,6 +944,8 @@ static int _of_add_opp_table_v1(struct device *dev, > struct opp_table *opp_table) > nr -= 2; > } > > + return 0; > + > remove_static_opp: > _opp_remove_all_static(opp_table); > > -- > 2.25.0.rc1.19.g042ed3e048af
| |