lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC PKS/PMEM 24/58] fs/freevxfs: Utilize new kmap_thread()
    > -	kaddr = kmap(pp);
    > + kaddr = kmap_thread(pp);
    > memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE);
    > - kunmap(pp);
    > + kunmap_thread(pp);

    You only Cced me on this particular patch, which means I have absolutely
    no idea what kmap_thread and kunmap_thread actually do, and thus can't
    provide an informed review.

    That being said I think your life would be a lot easier if you add
    helpers for the above code sequence and its counterpart that copies
    to a potential hughmem page first, as that hides the implementation
    details from most users.

    \
     
     \ /
      Last update: 2020-10-13 13:27    [W:5.444 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site