lkml.org 
[lkml]   [2020]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 08/13] m68k: m68328: use legacy_timer_tick()
    Hi Arnd,

    On Thu, Oct 8, 2020 at 5:48 PM Arnd Bergmann <arnd@arndb.de> wrote:
    > A couple of machines share the m68328 timer code that
    > is based on calling timer_interrupt(). Change these
    > to the new and slightly more generic legacy_timer_tick()
    > helper.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Thanks for your patch!

    > --- a/arch/m68k/Kconfig.machine
    > +++ b/arch/m68k/Kconfig.machine
    > @@ -146,6 +146,7 @@ config PILOT
    > config PILOT3
    > bool "Pilot 1000/5000, PalmPilot Personal/Pro, or PalmIII support"
    > depends on M68328
    > + select LEGACY_TIMER_TICK
    > select PILOT
    > help
    > Support for the Palm Pilot 1000/5000, Personal/Pro and PalmIII.
    > @@ -159,18 +160,21 @@ config XCOPILOT_BUGS
    > config UCSIMM
    > bool "uCsimm module support"
    > depends on M68EZ328
    > + select LEGACY_TIMER_TICK
    > help
    > Support for the Arcturus Networks uCsimm module.
    >
    > config UCDIMM
    > bool "uDsimm module support"
    > depends on M68VZ328
    > + select LEGACY_TIMER_TICK
    > help
    > Support for the Arcturus Networks uDsimm module.
    >
    > config DRAGEN2
    > bool "DragenEngine II board support"
    > depends on M68VZ328
    > + select LEGACY_TIMER_TICK
    > help
    > Support for the DragenEngine II board.

    Given this feature is SoC-specific, not platform-specific, perhaps
    it makes sense to move the selects to the M68{,EZ,VZ}328 symbols?

    Regardless:
    Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

    Gr{oetje,eeting}s,

    Geert


    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-10-12 15:15    [W:4.125 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site