Messages in this thread | | | Date | Mon, 12 Oct 2020 10:38:29 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [Cocci] [PATCH v4 1/3] scripts: coccicheck: Add quotes to improve portability |
| |
On Sun, 11 Oct 2020, Sumera Priyadarsini wrote:
> While fetching the number of threads per core with lscpu, > the [:digit:] set is used for translation of digits from 0-9. > However, using [:digit:] instead of "[:digit:]" does not seem > to work uniformly for some shell types and configurations > (such as zsh). > > Therefore, modify coccicheck to use double quotes around the > [:digit:] set for uniformity and better portability. > > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Applied, thanks.
> --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index 6789751607f5..d67907b8a38b 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -76,7 +76,7 @@ else > fi > > # Use only one thread per core by default if hyperthreading is enabled > - THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd [:digit:]) > + THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]") > if [ -z "$J" ]; then > NPROC=$(getconf _NPROCESSORS_ONLN) > if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 2 ] ; then > -- > 2.25.1 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci >
| |