| Date | Mon, 12 Oct 2020 09:01:44 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump |
| |
On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: > @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct ordered_events *oe, > ordered_events); > > return perf_session__deliver_event(session, event->event, > - session->tool, event->file_offset); > + session->tool, event->file_offset, > + event->file_path);
Wouldn't it be better to pass "event" around now, which would contain at least four of the arguments.
These functions are getting entirely too many arguments.
-Andi
|