lkml.org 
[lkml]   [2020]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] net/ipv6: use semicolons rather than commas to separate statements
    Date
    Replace commas with semicolons.  Commas introduce unnecessary
    variability in the code structure and are hard to see. What is done
    is essentially described by the following Coccinelle semantic patch
    (http://coccinelle.lip6.fr/):

    // <smpl>
    @@ expression e1,e2; @@
    e1
    -,
    +;
    e2
    ... when any
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

    ---
    net/ipv6/calipso.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv6/calipso.c b/net/ipv6/calipso.c
    index 8d3f66c310db..78f766019b7e 100644
    --- a/net/ipv6/calipso.c
    +++ b/net/ipv6/calipso.c
    @@ -761,7 +761,7 @@ static int calipso_genopt(unsigned char *buf, u32 start, u32 buf_len,
    calipso[1] = len - 2;
    *(__be32 *)(calipso + 2) = htonl(doi_def->doi);
    calipso[6] = (len - CALIPSO_HDR_LEN) / 4;
    - calipso[7] = secattr->attr.mls.lvl,
    + calipso[7] = secattr->attr.mls.lvl;
    crc = ~crc_ccitt(0xffff, calipso, len);
    calipso[8] = crc & 0xff;
    calipso[9] = (crc >> 8) & 0xff;
    \
     
     \ /
      Last update: 2020-10-11 13:19    [W:4.473 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site