Messages in this thread Patch in this message | | | From | trix@redhat ... | Subject | [PATCH] ptp: ptp_clockmatrix: initialize variables | Date | Sun, 11 Oct 2020 13:09:55 -0700 |
| |
From: Tom Rix <trix@redhat.com>
Clang static analysis reports this representative problem
ptp_clockmatrix.c:1852:2: warning: 5th function call argument is an uninitialized value snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
idtcm_display_version_info() calls several idtcm_read_*'s without checking a return status. Initialize the read variables so if a read fails, a garbage value is not displayed.
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/ptp/ptp_clockmatrix.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index e020faff7da5..47e5e62da5d2 100644 --- a/drivers/ptp/ptp_clockmatrix.c +++ b/drivers/ptp/ptp_clockmatrix.c @@ -1832,12 +1832,12 @@ static int idtcm_enable_tod(struct idtcm_channel *channel) static void idtcm_display_version_info(struct idtcm *idtcm) { - u8 major; - u8 minor; - u8 hotfix; - u16 product_id; - u8 hw_rev_id; - u8 config_select; + u8 major = 0; + u8 minor = 0; + u8 hotfix = 0; + u16 product_id = 0; + u8 hw_rev_id = 0; + u8 config_select = 0; char *fmt = "%d.%d.%d, Id: 0x%04x HW Rev: %d OTP Config Select: %d\n"; idtcm_read_major_release(idtcm, &major); -- 2.18.1
| |