Messages in this thread | | | Date | Sun, 11 Oct 2020 19:01:02 +0100 | From | Al Viro <> | Subject | Re: [PATCH 5/5] fs: remove do_mounts |
| |
On Sun, Oct 11, 2020 at 07:17:49AM -0700, Guenter Roeck wrote:
> Someone didn't bother test building this patch. > > arch/alpha/kernel/osf_sys.c: In function '__do_sys_osf_mount': > arch/alpha/kernel/osf_sys.c:437:14: error: 'path' redeclared as different kind of symbol
Quite. Matter of fact, there's another problem (path_mount() that needs to be moved from fs/internal.h for that) and IMO this is simply not worth bothering with. I don't see any benefits in the last commit in there; the next-to-last one has some point, and it's not hard to fix, but since it clearly got no testing whatsoever... Christoph, if you want it back, resend it later, *after* having tested it. qemu-system-alpha works well enough to boot the last released debian/alpha.
For now I'm dropping the last two commits from that branch.
| |