Messages in this thread | | | Date | Thu, 1 Oct 2020 13:15:40 +0530 | From | Anmol Karn <> | Subject | Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet() |
| |
On Thu, Oct 01, 2020 at 09:06:42AM +0200, Marcel Holtmann wrote: > Hi Anmol, > > > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called from hci_event_packet() and there is a possibility, that hcon->amp_mgr may not be found when accessing after initialization of hcon. > > > > - net/bluetooth/hci_event.c:4945 > > The bug seems to get triggered in this line: > > > > bredr_hcon = hcon->amp_mgr->l2cap_conn->hcon; > > > > Fix it by adding a NULL check for the hcon->amp_mgr before checking the ev-status. > > > > Fixes: d5e911928bd8 ("Bluetooth: AMP: Process Physical Link Complete evt") > > Reported-and-tested-by: syzbot+0bef568258653cff272f@syzkaller.appspotmail.com > > Link: https://syzkaller.appspot.com/bug?extid=0bef568258653cff272f > > Signed-off-by: Anmol Karn <anmol.karan123@gmail.com> > > --- > > Change in v3: > > - changed return o; to return; (Reported-by: kernel test robot <lkp@intel.com> > > ) > > > > net/bluetooth/hci_event.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > patch has been applied to bluetooth-next tree. > > Regards > > Marcel >
Thank you :)
Best, Anmol
| |