lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] perf record: Support synthesizing cgroup events
On Tue, Jan 07, 2020 at 10:34:58PM +0900, Namhyung Kim wrote:

SNIP

> + closedir(d);
> + return ret;
> +}
> +
> +int perf_event__synthesize_cgroups(struct perf_tool *tool,
> + perf_event__handler_t process,
> + struct machine *machine)
> +{
> + union perf_event event;
> + char *cgrp_root;
> + size_t mount_len; /* length of mount point in the path */
> + int ret = -1;
> +
> + cgrp_root = malloc(PATH_MAX);
> + if (cgrp_root == NULL)
> + return -1;
> +

hum, we normally use bufs with PATH_MAX size on stack..
is there some reason to use heap in here?

jirka


> + if (cgroupfs_find_mountpoint(cgrp_root, PATH_MAX) < 0) {
> + pr_debug("cannot find cgroup mount point\n");
> + goto out;
> + }
> +
> + mount_len = strlen(cgrp_root);
> + /* make sure the path starts with a slash (after mount point) */
> + strcat(cgrp_root, "/");
> +
> + if (perf_event__walk_cgroup_tree(tool, &event, cgrp_root, mount_len,
> + process, machine) < 0)
> + goto out;
> +
> + ret = 0;
> +
> +out:
> + free(cgrp_root);
> +
> + return ret;
> +}
> +

SNIP

\
 
 \ /
  Last update: 2020-01-08 23:23    [W:0.136 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site