Messages in this thread | | | Date | Tue, 7 Jan 2020 08:26:45 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 2/2] pwm: Enable compile testing for some of drivers |
| |
Hello Krzysztof,
On Mon, Dec 30, 2019 at 06:21:13PM +0100, Krzysztof Kozlowski wrote: > Some of the PWM drivers can be compile tested to increase build > coverage. > > The Meson PWM driver requires COMMON_CLK dependency.
I'm surprised that there are not more that need this. Is HAVE_CLK not enough?
Also HAS_IOMEM is a typical requirement, but I tested with an ARCH=um config (which does't have HAS_IOMEM) and they all compile fine.
> @@ -318,7 +319,7 @@ config PWM_MEDIATEK > > config PWM_MXS > tristate "Freescale MXS PWM support" > - depends on ARCH_MXS && OF > + depends on (ARCH_MXS && OF) || COMPILE_TEST > select STMP_DEVICE > help > Generic PWM framework driver for Freescale MXS. > @@ -328,7 +329,8 @@ config PWM_MXS > > config PWM_OMAP_DMTIMER > tristate "OMAP Dual-Mode Timer PWM support" > - depends on OF && ARCH_OMAP && OMAP_DM_TIMER > + depends on (ARCH_OMAP && OMAP_DM_TIMER) || COMPILE_TEST > + depends on OF
I'm surprised that OF isn't required for PWM_MXS but is is for PWM_OMAP_DMTIMER. pwm-mxs compiles without CONFIG_OF, didn't test pwm-omap-dmtimer.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | | https://www.pengutronix.de/ |
| |