lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] i2c: highlander: Use proper printk format for iomem pointer
From
Date
Hi,

On 30/12/19 18:27, Krzysztof Kozlowski wrote:
> iomem pointers should be printed with pointer format to hide the

s/iomem/size_t/ (in the subject too)

The whole commit message needs rewording accordingly.

> actual value and fix warnings when compiling on 64-bit platform (e.g. with
> COMPILE_TEST):
>
> drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
> drivers/i2c/busses/i2c-highlander.c:325:22: warning:
> format ‘%d’ expects argument of type ‘int’,
> but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-highlander.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c
> index abfe3094c047..803dad70e2a7 100644
> --- a/drivers/i2c/busses/i2c-highlander.c
> +++ b/drivers/i2c/busses/i2c-highlander.c
> @@ -322,7 +322,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr,
> tmp |= (SMMR_MODE0 | SMMR_MODE1);
> break;
> default:
> - dev_err(dev->dev, "unsupported xfer size %d\n", dev->buf_len);
> + dev_err(dev->dev, "unsupported xfer size %zu\n", dev->buf_len);
> return -EINVAL;
> }
>
>

--
Luca

\
 
 \ /
  Last update: 2020-01-07 16:09    [W:0.064 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site