lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next] enetc: Fix inconsistent IS_ERR and PTR_ERR
On Tue, 7 Jan 2020 at 16:16, YueHaibing <yuehaibing@huawei.com> wrote:
>
> The proper pointer to be passed as argument is hw
> Detected using Coccinelle.
>
> Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks a lot!

> drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> index 87c0e96..ebc635f 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> @@ -27,7 +27,7 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
> }
>
> hw = enetc_hw_alloc(dev, port_regs);
> - if (IS_ERR(enetc_hw_alloc)) {
> + if (IS_ERR(hw)) {
> err = PTR_ERR(hw);
> goto err_hw_alloc;
> }
> --
> 2.7.4
>
>

-Vladimir

\
 
 \ /
  Last update: 2020-01-07 15:19    [W:0.272 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site