Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Tue, 7 Jan 2020 15:04:26 +0100 | Subject | Re: [PATCH] sh: clk: Fix discarding const qualifier warning |
| |
On Tue, 7 Jan 2020 at 14:54, Arnd Bergmann <arnd@arndb.de> wrote: > > arch/powerpc/kernel/iomap.cOn Tue, Jan 7, 2020 at 2:33 PM Krzysztof > Kozlowski <krzk@kernel.org> wrote: > > On Tue, Jan 07, 2020 at 02:05:14PM +0100, Krzysztof Kozlowski wrote: > > > On Tue, 7 Jan 2020 at 14:00, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > > Since this is a SuperH driver, I adjusted it to the SuperH > > > implementation - lack of const. However iIndeed it makes sense to have > > > them all taking "const"... Let me check, if I can fix it (without the > > > real HW). > > > > That will be non-trivial because many platforms define ioreadX() with > > non-const. For example entire alpha with many its implementations of > > ioread(). Even include/asm-generic/iomap.h defines them as non-const... > > I found these instances: > > arch/alpha/include/asm/io.h > arch/alpha/kernel/io.c > arch/parisc/include/asm/io.h > arch/parisc/lib/iomap.c > arch/sh/kernel/iomap.c > arch/powerpc/kernel/iomap.c > lib/iomap.c > include/asm-generic/iomap.h > > At least the last four file would have to be done at the same time as > the header is shared, but the actual conversion should be trivial.
Yes, assuming that I did not screw up some specific arch-implementation, it seems easy.
I have patchset ready - just need to build test it and I'll share for kbuild & company to test.
Best regards, Krzysztof
| |