lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 49/74] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work
    Date
    From: Roman Bolshakov <r.bolshakov@yadro.com>

    commit 600954e6f2df695434887dfc6a99a098859990cf upstream.

    del_work is already initialized inside qla2x00_alloc_fcport, there's no
    need to overwrite it. Indeed, it might prevent complete traversal of
    workqueue list.

    Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue")
    Cc: Quinn Tran <qutran@marvell.com>
    Link: https://lore.kernel.org/r/20191125165702.1013-5-r.bolshakov@yadro.com
    Acked-by: Himanshu Madhani <hmadhani@marvell.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Tested-by: Hannes Reinecke <hare@suse.de>
    Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla2xxx/qla_target.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/scsi/qla2xxx/qla_target.c
    +++ b/drivers/scsi/qla2xxx/qla_target.c
    @@ -1210,7 +1210,6 @@ void qlt_schedule_sess_for_deletion(stru
    "Scheduling sess %p for deletion %8phC\n",
    sess, sess->port_name);

    - INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn);
    queue_work(sess->vha->hw->wq, &sess->del_work);
    }


    \
     
     \ /
      Last update: 2020-01-07 22:17    [W:4.260 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site