lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 062/191] ALSA: hda - Downgrade error message for single-cmd fallback
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit 475feec0c41ad71cb7d02f0310e56256606b57c5 ]

    We made the error message for the CORB/RIRB communication clearer by
    upgrading to dev_WARN() so that user can notice better. But this
    struck us like a boomerang: now it caught syzbot and reported back as
    a fatal issue although it's not really any too serious bug that worth
    for stopping the whole system.

    OK, OK, let's be softy, downgrade it to the standard dev_err() again.

    Fixes: dd65f7e19c69 ("ALSA: hda - Show the fatal CORB/RIRB error more clearly")
    Reported-by: syzbot+b3028ac3933f5c466389@syzkaller.appspotmail.com
    Link: https://lore.kernel.org/r/20191216151224.30013-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_controller.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
    index 6387c7e90918..76b507058cb4 100644
    --- a/sound/pci/hda/hda_controller.c
    +++ b/sound/pci/hda/hda_controller.c
    @@ -884,7 +884,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,
    return -EAGAIN; /* give a chance to retry */
    }

    - dev_WARN(chip->card->dev,
    + dev_err(chip->card->dev,
    "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",
    bus->last_cmd[addr]);
    chip->single_cmd = 1;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-07 22:11    [W:2.670 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site