Messages in this thread | | | Subject | Re: [PATCH] usb: ohci-da8xx: ensure error return on variable error is set | From | Sergei Shtylyov <> | Date | Mon, 6 Jan 2020 19:06:06 +0300 |
| |
On 01/06/2020 04:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com> > > Currently when an error in da8xx_ohci->oc_gpi occurs causes an
s/gpi/gpio/. And you missed a noun between 2 verbs.
> uninitialized error value in variable 'error' to be returned. > Fix this by ensuring the error variable is set to the error value > in da8xx_ohci->oc_gpi.
oc_gpio again.
> Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios") > Signed-off-by: Colin Ian King <colin.king@canonical.com> [...]
MBR, Sergei
| |