lkml.org 
[lkml]   [2020]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 12/12] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage
    Date
    It's good to have basic unit test coverage of the new FOLL_PIN
    behavior. Fortunately, the gup_benchmark unit test is extremely
    fast (a few milliseconds), so adding it the the run_vmtests suite
    is going to cause no noticeable change in running time.

    So, add two new invocations to run_vmtests:

    1) Run gup_benchmark with normal get_user_pages().

    2) Run gup_benchmark with pin_user_pages(). This is much like
    the first call, except that it sets FOLL_PIN.

    Running these two in quick succession also provide a visual
    comparison of the running times, which is convenient.

    The new invocations are fairly early in the run_vmtests script,
    because with test suites, it's usually preferable to put the
    shorter, faster tests first, all other things being equal.

    Reviewed-by: Ira Weiny <ira.weiny@intel.com>
    Signed-off-by: John Hubbard <jhubbard@nvidia.com>
    ---
    tools/testing/selftests/vm/run_vmtests | 22 ++++++++++++++++++++++
    1 file changed, 22 insertions(+)

    diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests
    index a692ea828317..df6a6bf3f238 100755
    --- a/tools/testing/selftests/vm/run_vmtests
    +++ b/tools/testing/selftests/vm/run_vmtests
    @@ -112,6 +112,28 @@ echo "NOTE: The above hugetlb tests provide minimal coverage. Use"
    echo " https://github.com/libhugetlbfs/libhugetlbfs.git for"
    echo " hugetlb regression testing."

    +echo "--------------------------------------------"
    +echo "running 'gup_benchmark -U' (normal/slow gup)"
    +echo "--------------------------------------------"
    +./gup_benchmark -U
    +if [ $? -ne 0 ]; then
    + echo "[FAIL]"
    + exitcode=1
    +else
    + echo "[PASS]"
    +fi
    +
    +echo "------------------------------------------"
    +echo "running gup_benchmark -b (pin_user_pages)"
    +echo "------------------------------------------"
    +./gup_benchmark -b
    +if [ $? -ne 0 ]; then
    + echo "[FAIL]"
    + exitcode=1
    +else
    + echo "[PASS]"
    +fi
    +
    echo "-------------------"
    echo "running userfaultfd"
    echo "-------------------"
    --
    2.25.0
    \
     
     \ /
      Last update: 2020-02-01 04:41    [W:3.405 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site