lkml.org 
[lkml]   [2020]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] tracing: Consolidate some synth_event_trace code
From
Date
Hi Steve,

On Fri, 2020-01-31 at 17:43 -0500, Steven Rostedt wrote:
> On Fri, 31 Jan 2020 15:55:31 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -2053,24 +2053,72 @@ int synth_event_trace_start(struct
> > trace_event_file *file,
> > }
> > EXPORT_SYMBOL_GPL(synth_event_trace_start);
> >
> > -static int save_synth_val(struct synth_field *field, u64 val,
> > +int __synth_event_add_val(const char *field_name, u64 val,
>
> Hmm, shouldn't __synth_event_add_val() still be static?
>

It's a new function, but yeah, it should be static.

Tom

> -- Steve
>
> > struct synth_event_trace_state
> > *trace_state)
> > {
> > - struct synth_trace_event *entry = trace_state->entry;
> > + struct synth_field *field = NULL;
> > + struct synth_trace_event *entry;
> > + struct synth_event *event;
> > + int i, ret = 0;
> > +

\
 
 \ /
  Last update: 2020-01-31 23:49    [W:0.102 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site