lkml.org 
[lkml]   [2020]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Intel PMC TGPIO Driver 1/5] drivers/ptp: Add Enhanced handling of reserve fields
    From
    Date
    On 12/11/2019 1:48 PM, christopher.s.hall@intel.com wrote:
    > From: Christopher Hall <christopher.s.hall@intel.com>
    >
    > Add functions that parameterize checking and zeroing of reserve fields in
    > ioctl arguments. Eliminates need to change this code when repurposing
    > reserve fields.
    >

    One thing to note that may be problematic with this handling: a later
    usage of a reserved field must still be reported as zero for callers of
    the old ioctl variants. Reserved fields were only handled properly in
    the "2" variants of the ioctls.

    This change might make it harder to notice and remember to ensure that
    previously unused fields get zero'd for the old ioctls.

    Richard, thoughts?

    Thanks,
    Jake

    \
     
     \ /
      Last update: 2020-01-31 18:02    [W:3.422 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site