lkml.org 
[lkml]   [2020]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 074/110] HID: steam: Fix input device disappearing
    Date
    From: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>

    [ Upstream commit 20eee6e5af35d9586774e80b6e0b1850e7cc9899 ]

    The `connected` value for wired devices was not properly initialized,
    it must be set to `true` upon creation, because wired devices do not
    generate connection events.

    When a raw client (the Steam Client) uses the device, the input device
    is destroyed. Then, when the raw client finishes, it must be recreated.
    But since the `connected` variable was false this never happended.

    Signed-off-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-steam.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c
    index 8dae0f9b819e0..6286204d4c560 100644
    --- a/drivers/hid/hid-steam.c
    +++ b/drivers/hid/hid-steam.c
    @@ -768,8 +768,12 @@ static int steam_probe(struct hid_device *hdev,

    if (steam->quirks & STEAM_QUIRK_WIRELESS) {
    hid_info(hdev, "Steam wireless receiver connected");
    + /* If using a wireless adaptor ask for connection status */
    + steam->connected = false;
    steam_request_conn_status(steam);
    } else {
    + /* A wired connection is always present */
    + steam->connected = true;
    ret = steam_register(steam);
    if (ret) {
    hid_err(hdev,
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-30 19:52    [W:4.821 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site