Messages in this thread | | | Date | Thu, 30 Jan 2020 07:41:11 -0800 (PST) | From | Palmer Dabbelt <> | Subject | Re: [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver for QEMU virt machine |
| |
On Wed, 22 Jan 2020 19:49:54 GMT (+0000), Paul Walmsley wrote: > On Tue, 3 Dec 2019, Anup Patel wrote: > >> We select Goldfish RTC driver using QEMU virt machine kconfig option >> to access RTC device on QEMU virt machine. >> >> Signed-off-by: Anup Patel <anup.patel@wdc.com> >> Reviewed-by: Atish Patra <atish.patra@wdc.com> >> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > > I just grepped for Goldfish through the QEMU git tree, and it didn't come > up with anything. Per our discussion last year: as a general matter of > policy, until QEMU merges support for a simulated hardware device into > their master branch, we shouldn't speculatively enable support for it. > So, NAK from me on this one until that happens.
Thanks, I thought they were going in through a hw/rtc tree and forgot about them. I've queued them up for QEMU via the RISC-V tree, there's still some other patches I'd like to batch up but I'll send them up soon. I don't see any reason why the Linux patches can't go in via an early-ish RC, so we shoul be fine.
| |