Messages in this thread | | | Subject | Re: [PATCH 3/3] lib/find_bit.c: uninline helper _find_next_bit() | From | Joe Perches <> | Date | Fri, 03 Jan 2020 13:46:07 -0800 |
| |
On Fri, 2020-01-03 at 12:28 -0800, Yury Norov wrote: > It saves 25% of .text for arm64, and more for BE architectures.
This seems a rather misleading code size reduction description.
Please detail the specific code sizes using "size lib/find_bit.o" before and after this change.
Also, _find_next_bit is used 3 times, perhaps any code size increase is appropriate given likely reduced run time.
> Signed-off-by: Yury Norov <yury.norov@gmail.com> > --- > lib/find_bit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/find_bit.c b/lib/find_bit.c > index c03cbecb2b1f6..0e4b2b90c9c02 100644 > --- a/lib/find_bit.c > +++ b/lib/find_bit.c > @@ -27,7 +27,7 @@ > * searching it for one bits. > * - The optional "addr2", which is anded with "addr1" if present. > */ > -static inline unsigned long _find_next_bit(const unsigned long *addr1, > +static unsigned long _find_next_bit(const unsigned long *addr1, > const unsigned long *addr2, unsigned long nbits, > unsigned long start, unsigned long invert, unsigned long le) > {
| |