Messages in this thread | | | From | Peter Rosin <> | Subject | Re: [PATCH][next][V2] i2c: xiic: fix indentation issue | Date | Wed, 29 Jan 2020 08:06:32 +0000 |
| |
On 2020-01-29 00:10, Colin Ian King wrote: > On 28/01/2020 21:45, Peter Rosin wrote: >> On 2020-01-27 13:08, Colin Ian King wrote: >>> On 27/01/2020 12:05, Dan Carpenter wrote: >>>> On Mon, Jan 27, 2020 at 12:03:02PM +0100, Michal Simek wrote: >>>>> On 27. 01. 20 11:23, Colin King wrote: >>>>>> From: Colin Ian King <colin.king@canonical.com> >>>>>> >>>>>> There is a statement that is indented one level too deeply, remove >>>>>> the extraneous tab. >>>>>> >>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>>>>> --- >>>>>> V2: fix type in commit message >>>>>> --- >>>>>> drivers/i2c/busses/i2c-xiic.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c >>>>>> index b17d30c9ab40..90c1c362394d 100644 >>>>>> --- a/drivers/i2c/busses/i2c-xiic.c >>>>>> +++ b/drivers/i2c/busses/i2c-xiic.c >>>>>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) >>>>>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); >>>>>> if (time_after(jiffies, timeout)) { >>>>>> dev_err(i2c->dev, "Failed to clear rx fifo\n"); >>>>>> - return -ETIMEDOUT; >>>>>> + return -ETIMEDOUT; >>>>>> } >>>>>> } >>>>>> >>>>>> >>>>> >>>>> As was suggested by Peter you should also add Fixes: <sha1> ("patch >>>>> subject") >>>>> >>>> >>>> It's not really a bugfix, it's just a cleanup. >>> >>> I'm surprised i wasn't asked for a bug number too. >> >> Very funny. > > Apologies for being flippant. I didn't mean to offend. My bad #1.
Apology accepted, no hard feelings. Don't worry about it, and sorry on my part for a possible overreaction!
Cheers, Peter
| |