Messages in this thread | | | Date | Wed, 29 Jan 2020 20:42:33 +0100 | From | Greg KH <> | Subject | Re: [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1 |
| |
On Wed, Jan 29, 2020 at 10:11:26AM -0800, Linus Torvalds wrote: > On Wed, Jan 29, 2020 at 2:14 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > Here is the big USB and Thunderbolt and PHY driver updates for 5.6-rc1. > > Hmm. This actually causes a new warning even before I start building it: > > WARNING: unmet direct dependencies detected for I2C_S3C2410 > Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && HAVE_S3C2410_I2C [=n] > Selected by [m]: > - PHY_EXYNOS5250_SATA [=m] && (SOC_EXYNOS5250 || COMPILE_TEST > [=y]) && HAS_IOMEM [=y] && OF [=y] > > and the cause seems to be > > 203b7ee14d3a ("phy: Enable compile testing for some of drivers") > > where PHY_EXYNOS5250_SATA now has a > > depends on SOC_EXYNOS5250 || COMPILE_TEST > depends on HAS_IOMEM > depends on OF > > and then blindly does a > > select I2C_S3C2410 > > without having the dependencies that I2C_S3C2410 has. > > How did this ever pass any testing in linux-next without being > noticed, when I noticed within five seconds of pulling it? It > literally warns immediately on "make allmodconfig".
linux-next was fine as the fix was in the i2c tree. Sorry for not realizing it here as well, it didn't show up on my test builds as I wasn't doing 'allmodconfig' for USB stuff.
If it's any consolation, it was a lot worse, I did take some fixups for other issues like this that came in through here :)
But I should have caught this as well, sorry, and thanks for merging.
greg k-h
| |