lkml.org 
[lkml]   [2020]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] tracing: Add new testcases for hist trigger parsing errors
From
Date
Hi Steve,

On Wed, 2020-01-29 at 09:22 -0500, Steven Rostedt wrote:
> On Fri, 28 Jun 2019 12:40:23 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > Add a testcase ensuring that the tracing error_log correctly
> > displays
> > hist trigger parsing errors.
>
> Hi Tom,
>
> I noticed that I never applied these patches (just did), but I also
> notice that this test case fails.
>
> Can you have a look on my ftrace/core branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-
> trace.git
>

All the trigger testcases are passing for me, including this one:

# ./ftracetest test.d/trigger/trigger-hist-syntax-errors.tc
=== Ftrace unit tests ===
[1] event trigger - test histogram parser errors [PASS]


# of passed: 1
# of failed: 0
# of unresolved: 0
# of untested: 0
# of unsupported: 0
# of xfailed: 0
# of undefined(test bug): 0


Tom


> Thanks,
>
> -- Steve
>
> >
> > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> > Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > .../test.d/trigger/trigger-hist-syntax-errors.tc | 32
> > ++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> > create mode 100644
> > tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-
> > errors.tc
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-
> > hist-syntax-errors.tc
> > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-
> > syntax-errors.tc
> > new file mode 100644
> > index 000000000000..d44087a2f3d1
> > --- /dev/null
> > +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-
> > syntax-errors.tc
> > @@ -0,0 +1,32 @@
> > +#!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0
> > +# description: event trigger - test histogram parser errors
> > +
> > +if [ ! -f set_event -o ! -d events/kmem ]; then
> > + echo "event tracing is not supported"
> > + exit_unsupported
> > +fi
> > +
> > +if [ ! -f events/kmem/kmalloc/trigger ]; then
> > + echo "event trigger is not supported"
> > + exit_unsupported
> > +fi
> > +
> > +if [ ! -f events/kmem/kmalloc/hist ]; then
> > + echo "hist trigger is not supported"
> > + exit_unsupported
> > +fi
> > +
> > +[ -f error_log ] || exit_unsupported
> > +
> > +check_error() { # command-with-error-pos-by-^
> > + ftrace_errlog_check 'hist:kmem:kmalloc' "$1"
> > 'events/kmem/kmalloc/trigger'
> > +}
> > +
> > +check_error
> > 'hist:keys=common_pid:vals=bytes_req:sort=common_pid,^junk'
> > # INVALID_SORT_FIELD
> > +check_error 'hist:keys=common_pid:vals=bytes_req:^sort='
> > # EMPTY_ASSIGNMENT
> > +check_error
> > 'hist:keys=common_pid:vals=bytes_req:^sort=common_pid,' #
> > EMPTY_SORT_FIELD
> > +check_error
> > 'hist:keys=common_pid:vals=bytes_req:sort=common_pid.^junk'
> > # INVALID_SORT_MODIFIER
> > +check_error
> > 'hist:keys=common_pid:vals=bytes_req,bytes_alloc:^sort=common_pid,b
> > ytes_req,bytes_alloc' # TOO_MANY_SORT_FIELDS
> > +
> > +exit 0
>
>

\
 
 \ /
  Last update: 2020-01-29 15:45    [W:0.048 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site