Messages in this thread | | | Date | Mon, 27 Jan 2020 11:46:00 +0000 | From | Russell King - ARM Linux admin <> | Subject | Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY |
| |
On Mon, Jan 27, 2020 at 11:38:05AM +0000, Jose Abreu wrote: > From: Russell King - ARM Linux admin <linux@armlinux.org.uk> > Date: Jan/27/2020, 11:21:02 (UTC+00:00) > > > On Mon, Jan 27, 2020 at 12:09:11PM +0100, Jose Abreu wrote: > > > When we don't have any real PHY driver connected and we get link up from > > > PCS we shall configure MAC and PCS for the desired speed and also > > > resolve the flow control settings from MAC side. > > > > This is certainly the wrong place for it. Please hold off on this patch > > for the time being. Thanks. > > This is actually the change that makes everything work ... > > I need to configure PCS before Aneg is complete and then I need to > configure MAC once Aneg is done and link is up with the outcome speed and > flow control.
Yes, I realise that, but it comes with the expense of potentially breaking mvneta and mvpp2, where the settings are automatically passed between the PCS and MAC in hardware. I also believe DSA works around this, and I need to look at that.
However, right now I'm in the middle of rebasing my git tree on top of v5.5 and can't say much more until I've finished that.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
| |