Messages in this thread | | | Date | Sat, 25 Jan 2020 16:45:48 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH][RESEND] Input: hyperv-keyboard: Add the support of hibernation |
| |
On Sat, Jan 25, 2020 at 01:59:03AM +0000, Dexuan Cui wrote: >> From: linux-hyperv-owner@vger.kernel.org >> <linux-hyperv-owner@vger.kernel.org> On Behalf Of Dexuan Cui >> Sent: Wednesday, January 15, 2020 11:53 AM >> > ... >> > On Mon, Jan 06, 2020 at 02:40:44PM -0800, Dexuan Cui wrote: >> > >Add suspend() and resume() functions so the Hyper-V virtual keyboard >> > >can participate in VM hibernation. >> > > >> > >Note that the keyboard is a "wakeup" device that could abort an in-progress >> > >hibernation if there is keyboard event. No attempt is made to suppress >> > this >> > >behavior. If desired, a sysadmin can disable the keyboard as a wakeup >> > device >> > >using standard mechanisms such as: >> > > >> > >echo disabled > >> > /sys/bus/vmbus/drivers/hyperv_keyboard/XXX/power/wakeup >> > >(where XXX is the device's GUID) >> > > >> > >Reviewed-by: Michael Kelley <mikelley@microsoft.com> >> > >Signed-off-by: Dexuan Cui <decui@microsoft.com> >> > >--- >> > > >> > >This is a RESEND of https://lkml.org/lkml/2019/11/24/115 . >> > >> > >Please review. >> > > >> > >If it looks good, Sasha Levin, can you please pick it up via the >> > >hyperv/linux.git tree, as you did last time for this driver? >> > >> > This will need an ack from the input driver maintainers, unless they >> > want to give a blanket ack to this type of patches. >> > >> > Thanks, >> > Sasha >> >> Hi Dmitry, >> May I have your Acked-by for this patch? >> >> Thanks >> -- Dexuan > >It looks Dmitry may be on leave and there is no ACK from any input driver >maintainers. :-( > >Sasha, for this patch, I would suggest it may as well go directly through the >Hyper-V tree because >1. It's really small and it's a pure Hyper-V change. >2. This is for a new functionality and it can not break any existing code. >3. I'm pretty sure it can not cause any merge conflict or build failure. > >It's still wonderful to get an Ack or some comment from the input driver >maintainer(s), so maybe let's wait more time (e.g. a week?) and then I >suggust we proceed.
I'll queue it up via the hyperv tree, if anyone has any objections please let me know.
-- Thanks, Sasha
| |