lkml.org 
[lkml]   [2020]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 255/639] scsi: megaraid_sas: reduce module load time
    Hi!

    > [ Upstream commit 31b6a05f86e690e1818116fd23c3be915cc9d9ed ]
    >
    > megaraid_sas takes 1+ seconds to load while waiting for firmware:
    >
    > [2.822603] megaraid_sas 0000:03:00.0: Waiting for FW to come to ready state
    > [3.871003] megaraid_sas 0000:03:00.0: FW now in Ready state
    >
    > This is due to the following loop in megasas_transition_to_ready(), which
    > waits a minimum of 1 second, even though the FW becomes ready in tens of
    > millisecs:
    >
    > /*
    > * The cur_state should not last for more than max_wait secs
    > */
    > for (i = 0; i < max_wait; i++) {
    > ...
    > msleep(1000);
    > ...
    > dev_info(&instance->pdev->dev, "FW now in Ready state\n");
    >
    > This is a regression, caused by a change of the msleep granularity from 1
    > to 1000 due to concern about waiting too long on systems with coarse
    > jiffies.
    >
    > To fix, increase iterations and use msleep(20), which results in:
    >
    > [2.670627] megaraid_sas 0000:03:00.0: Waiting for FW to come to ready state
    > [2.739386] megaraid_sas 0000:03:00.0: FW now in Ready state
    >
    > Fixes: fb2f3e96d80f ("scsi: megaraid_sas: Fix msleep granularity")


    That commit does not exist, it seems this fixes:

    commit 9155cf30a3c4ef97e225d6daddf9bd4b173267e8
    scsi: megaraid_sas: Fix msleep granularity

    Best regards,
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-01-25 17:53    [W:3.039 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site