lkml.org 
[lkml]   [2020]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC net-next v3 02/10] net: bridge: mrp: Expose function br_mrp_port_open
    The 01/24/2020 18:37, Andrew Lunn wrote:
    > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
    >
    > On Fri, Jan 24, 2020 at 05:18:20PM +0100, Horatiu Vultur wrote:
    > > In case the HW is capable to detect when the MRP ring is open or closed. It is
    > > expected that the network driver will notify the bridge that the ring is open or
    > > closed.
    > >
    > > The function br_mrp_port_open is used to notify the kernel that one of the ports
    > > stopped receiving MRP_Test frames. The argument 'loc' has a value of '1' when
    > > the port stopped receiving MRP_Test and '0' when it started to receive MRP_Test.
    >
    > Hi Horatiu
    >
    > Given the name of the function, br_mrp_port_open(), how about replacing
    > loc with a bool with the name open?

    Hi Andrew,

    Well spotted, yes I will replace this in the next series.

    >
    > Andrew

    --
    /Horatiu

    \
     
     \ /
      Last update: 2020-01-25 12:30    [W:2.109 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site