lkml.org 
[lkml]   [2020]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [linux-sunxi] [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions
    Date
    Dne sobota, 25. januar 2020 ob 12:20:18 CET je Jernej Škrabec napisal(a):
    > Hi!
    >
    > Dne sobota, 25. januar 2020 ob 04:05:33 CET je Chen-Yu Tsai napisal(a):
    > > On Sat, Jan 25, 2020 at 7:20 AM Jernej Skrabec <jernej.skrabec@siol.net>
    >
    > wrote:
    > > > For some reason, A64 and H6 have swapped clocks and resets definitions.
    > > > H6 doesn't have rotation unit while A64 has. Swap around to correct the
    > > > issue.
    > > >
    > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
    > >
    > > Could you add Fixes tags for this one?
    >
    > I'm not sure which commit to reference. H6 one? or also initial A64 one?
    >
    > I just found out that H5 compatible uses A64 structure, which is not
    > correct. H5 doesn't contain rotate core.
    >
    > Do you have any better idea how to nicely solve this mess? I'm thinking that
    > for v2 I would first decouple some compatibles, like this for H5 and R40
    > and V3s from A83T (as it can be seen in the next patch). After that, rather
    > than switching definitions I would fix each compatible one by one. At the
    > end, if any entry is duplicated, I can add one commit to merge same
    > structures.

    This could also be a separate series of patches on which rotate driver series
    depends on.

    Best regards,
    Jernej




    \
     
     \ /
      Last update: 2020-01-25 12:25    [W:3.415 / U:2.824 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site