lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 478/639] scsi: libfc: fix null pointer dereference on a null lport
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 41a6bf6529edd10a6def42e3b2c34a7474bcc2f5 ]

    Currently if lport is null then the null lport pointer is dereference when
    printing out debug via the FC_LPORT_DB macro. Fix this by using the more
    generic FC_LIBFC_DBG debug macro instead that does not use lport.

    Addresses-Coverity: ("Dereference after null check")
    Fixes: 7414705ea4ae ("libfc: Add runtime debugging with debug_logging module parameter")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/libfc/fc_exch.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
    index 42bcf7f3a0f90..6ba257cbc6d94 100644
    --- a/drivers/scsi/libfc/fc_exch.c
    +++ b/drivers/scsi/libfc/fc_exch.c
    @@ -2603,7 +2603,7 @@ void fc_exch_recv(struct fc_lport *lport, struct fc_frame *fp)

    /* lport lock ? */
    if (!lport || lport->state == LPORT_ST_DISABLED) {
    - FC_LPORT_DBG(lport, "Receiving frames for an lport that "
    + FC_LIBFC_DBG("Receiving frames for an lport that "
    "has not been initialized correctly\n");
    fc_frame_free(fp);
    return;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:27    [W:4.035 / U:0.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site